chore: Update version flow updates deployment #4852

arcoraven · 2024-09-30T18:26:25Z

Problem solved

Changes the "update Engine version" flow to query the infra backend to perform the version upgrade.

Previously this would ping Slack for a thirdweb staff to update.

PR-Codex overview

This PR primarily focuses on improving the code quality and user interface of the dashboard components by updating placeholders, fixing text formatting, and refactoring function names for clarity. It also enhances the update functionality for the Engine version.

Detailed summary

Updated placeholder in ip-allowlist.tsx for consistency.
Added periods to sentences in EngineImportPage.tsx and CreateEnginePage.tsx.
Simplified conditional rendering in engine-instances-table.tsx.
Changed cloudDeployedAt to deploymentId for clarity in useEngine.ts.
Renamed useEngineUpdateVersion to useEngineUpdateServerVersion.
Modified API endpoint and method in useEngineUpdateServerVersion.
Updated variable names for better readability in EngineVersionBadge.
Refactored UpdateVersionModal to use latestVersion instead of latest.
Improved user feedback messages during engine updates.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-09-30T18:26:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 7:12am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 2, 2024 7:12am
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 2, 2024 7:12am
wallet-ui	⬜️ Skipped (Inspect)	Oct 2, 2024 7:12am

changeset-bot · 2024-09-30T18:26:29Z

⚠️ No Changeset found

Latest commit: 522968a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-09-30T18:26:31Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codecov · 2024-09-30T18:31:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (454f063) to head (522968a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4852   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files        1054     1054           
  Lines       57164    57164           
  Branches     3917     3917           
=======================================
  Hits        27212    27212           
  Misses      29263    29263           
  Partials      689      689

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 454f063
packages	`43.35% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-09-30T18:31:55Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.98 KB (0%)	840 ms (0%)	605 ms (-1.34% 🔽)	1.5 s
thirdweb (cjs)	101.58 KB (0%)	2.1 s (0%)	958 ms (+16.35% 🔺)	3 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	91 ms (+75.28% 🔺)	187 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	7 ms (-71.16% 🔽)	17 ms
thirdweb/react (minimal + tree-shaking)	16.75 KB (0%)	335 ms (0%)	113 ms (+68.33% 🔺)	448 ms

MananTank · 2024-09-30T23:16:55Z

apps/dashboard/src/components/engine/badges/version.tsx

+          <DialogDescription>
+            {`It is recommended to pause traffic to Engine before performing this
+            upgrade. There is < 1 minute of expected downtime.`}
+          </DialogDescription>


Nit: Don't need to wrap entire text with {``} here - just "<"

There's a < in the string, so I either need to do this or <. I generally don't like the latter cause it makes it hard to grep for it in code.

you should use the latter

arcoraven · 2024-09-30T23:44:14Z

I'm holding off on merging this until we have a PR that fixes a bug in upgrades introduced in one of the Engine versions.

jnsdls · 2024-10-01T01:37:42Z

apps/dashboard/src/components/engine/badges/version.tsx

+          <DialogDescription>
+            {`It is recommended to pause traffic to Engine before performing this
+            upgrade. There is < 1 minute of expected downtime.`}
+          </DialogDescription>


you should use the latter

graphite-app · 2024-10-02T07:08:38Z

Merge activity

Oct 2, 3:08 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 2, 3:08 AM EDT: arcoraven added this pull request to the Graphite merge queue.
Oct 2, 3:12 AM EDT: arcoraven merged this pull request with the Graphite merge queue.

## Problem solved Changes the "update Engine version" flow to query the infra backend to perform the version upgrade. Previously this would ping Slack for a thirdweb staff to update.  --- ## PR-Codex overview This PR focuses on improving the code quality and user interface across various components in the dashboard. It includes updates to placeholders, text content, and the handling of engine updates. ### Detailed summary - Updated `placeholder` in `ip-allowlist.tsx` to use curly braces. - Added periods to sentences in `EngineImportPage.tsx` and `CreateEnginePage.tsx`. - Simplified conditional rendering in `engine-instances-table.tsx`. - Changed `cloudDeployedAt` to `deploymentId` in `useEngine.ts`. - Renamed `useEngineUpdateVersion` to `useEngineUpdateServerVersion`. - Updated fetch method to `PUT` for engine updates. - Changed variable names for clarity in `EngineVersionBadge.tsx`. - Updated props in `UpdateVersionModal` to use `latestVersion`. - Adjusted toast messages for better user feedback during engine updates. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

arcoraven requested review from MananTank, jnsdls and joaquim-verges as code owners September 30, 2024 18:26

github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 30, 2024

vercel bot temporarily deployed to Preview – docs-v2 September 30, 2024 18:28 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 30, 2024 18:28 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 30, 2024 18:28 Inactive

vercel bot deployed to Preview – thirdweb-www September 30, 2024 18:41 View deployment

MananTank reviewed Sep 30, 2024

View reviewed changes

MananTank approved these changes Sep 30, 2024

View reviewed changes

jnsdls approved these changes Oct 1, 2024

View reviewed changes

vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 05:27 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 05:27 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 05:27 Inactive

vercel bot deployed to Preview – thirdweb-www October 1, 2024 05:36 View deployment

arcoraven enabled auto-merge (squash) October 2, 2024 05:24

vercel bot deployed to Preview – thirdweb_playground October 2, 2024 05:25 View deployment

vercel bot deployed to Preview – wallet-ui October 2, 2024 05:25 View deployment

vercel bot deployed to Preview – docs-v2 October 2, 2024 05:27 View deployment

vercel bot deployed to Preview – thirdweb-www October 2, 2024 05:35 View deployment

joaquim-verges approved these changes Oct 2, 2024

View reviewed changes

arcoraven disabled auto-merge October 2, 2024 07:08

arcoraven enabled auto-merge (squash) October 2, 2024 07:08

arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 2, 2024

arcoraven force-pushed the ph/engineVersionUpgrade branch from 773ec44 to 522968a Compare October 2, 2024 07:09

vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 07:09 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 07:09 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 07:09 Inactive

vercel bot deployed to Preview – thirdweb-www October 2, 2024 07:12 View deployment

graphite-app bot merged commit 522968a into main Oct 2, 2024
26 checks passed

graphite-app bot deleted the ph/engineVersionUpgrade branch October 2, 2024 07:12

vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 07:13 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 07:13 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 07:13 Inactive

vercel bot deployed to Production – thirdweb-www October 2, 2024 07:21 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Update version flow updates deployment #4852

chore: Update version flow updates deployment #4852

Uh oh!

arcoraven commented Sep 30, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 30, 2024

Uh oh!

codecov bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

MananTank Sep 30, 2024 •

edited

Loading

Uh oh!

arcoraven Sep 30, 2024

Uh oh!

jnsdls Oct 1, 2024

Uh oh!

arcoraven commented Sep 30, 2024

Uh oh!

jnsdls Oct 1, 2024

Uh oh!

graphite-app bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chore: Update version flow updates deployment #4852

chore: Update version flow updates deployment #4852

Uh oh!

Conversation

arcoraven commented Sep 30, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

codecov bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

MananTank Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arcoraven Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

arcoraven commented Sep 30, 2024

Uh oh!

jnsdls Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arcoraven commented Sep 30, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Sep 30, 2024 •

edited

Loading

changeset-bot bot commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

MananTank Sep 30, 2024 •

edited

Loading

graphite-app bot commented Oct 2, 2024 •

edited

Loading